-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid integer overflow when constructing arrays #26
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
===========================================
- Coverage 100.00% 98.57% -1.43%
===========================================
Files 1 1
Lines 58 70 +12
===========================================
+ Hits 58 69 +11
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
`Core.checked_dims` isn't public.
checked_dims_impl(m, r)::Int | ||
end | ||
|
||
checked_dims(::Tuple{}) = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method doesn't seem to be actually used? Or are there constructors I'm missing that'd call it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should call it, I'll add a test:
julia> using FixedSizeArrays
julia> FixedSizeArray{Int,0}(undef, ())
0-dimensional FixedSizeArray{Int64, 0}:
0
Seems to be a Julia code coverage bug. I get the same result when I run The method get's explicitly called here, but it's not marked as covered: d0bde93#diff-3b9314a6f9f2d7eec1d0ef69fa76cfabafdbe6d0df923768f9ec32f27a249c63R26 |
No description provided.